[gcc 4.8] Fix compilation failure for EXPECT_EQ reported due to -Werror=conversion-null in cast_soc…

[gcc 4.8] Fix compilation failure for EXPECT_EQ reported due to -Werror=conversion-null in cast_socket_unittest.cc

gcc 4.8 is throwing the error during compilation with -Werror=conversion-null. Suggested usage is of EXPECT_FALSE.

BUG=395935, 139326
TBR=yoz

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285922

[vivekg, 2014-07-28 09:10:09]

PTAL, thanks!

[vivekg, 2014-07-28 09:22:16]

This doesn't look good as EXPECT_EQ is defined as (expected, actual) but this is
how the build is passing. One more thing, there are quite few places where this
works "as is" in
https://code.google.com/p/chromium/codesearch#search/&q=EXPECT_EQ%5C(false,.*...

Don't understand how this is a different behavior.

[vivekg, 2014-07-28 09:29:18]

On 2014/07/28 09:22:16, vivekg_ wrote:
> This doesn't look good as EXPECT_EQ is defined as (expected, actual) but this
is
> how the build is passing. One more thing, there are quite few places where
this
> works "as is" in
>
https://code.google.com/p/chromium/codesearch#search/&q=EXPECT_EQ%5C(false,.*...
> 
> Don't understand how this is a different behavior.

Found already reported issue on crbug.com here [1] which states usage of
EXPECT_FALSE over EXPECT_EQ

[1] https://code.google.com/p/chromium/issues/detail?id=139326

[vivekg, 2014-07-28 09:34:18]

Looks like this has been doing few more rounds here [1]

Relevant gtest bug report here [2]

[1] https://code.google.com/p/chromium/issues/detail?id=173570
[2] https://code.google.com/p/googletest/issues/detail?id=322

[Nico, 2014-07-28 13:16:43]

lgtm

(clang used to need this too:
https://codereview.chromium.org/6614024/https://codereview.chromium.org/3645004/
etc ; I wonder why it didn't need it here)

[vivekg, 2014-07-28 14:16:44]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-28 14:17:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/421233002/20001

[commit-bot: I haz the power, 2014-07-28 16:23:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-28 16:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 16:26:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2014-07-28 16:27:00]

yoz: tbr for extensions/OWNERS

[Nico, 2014-07-28 16:27:03]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-07-28 16:28:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/421233002/20001

[commit-bot: I haz the power, 2014-07-28 16:30:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-28 16:34:24]

Change committed as 285922

[Kevin M, 2014-07-28 17:19:48]

On 2014/07/28 16:34:24, I haz the power (commit-bot) wrote:
> Change committed as 285922

Thanks!