Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 421213004: Fixed Compilation Warnings from Aw Files. (Closed)

Created:
6 years, 4 months ago by AKVT
Modified:
6 years, 4 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed Compilation Warnings from Aw Files. Fixed Compilation Warnings from Aw files. BUG=391252 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +4 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/FullScreenView.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
AKVT
PTAL
6 years, 4 months ago (2014-07-28 11:46:16 UTC) #1
AKVT
On 2014/07/28 11:46:16, AKV wrote: > PTAL @benm and boliu PTAL this compilation warning fix.
6 years, 4 months ago (2014-07-30 13:38:01 UTC) #2
benm (inactive)
AwContents lgtm +igsolla for FullScreenVideo
6 years, 4 months ago (2014-07-30 13:48:37 UTC) #3
Ignacio Solla
On 2014/07/30 13:48:37, benm wrote: > AwContents lgtm > +igsolla for FullScreenVideo Thanks for doing ...
6 years, 4 months ago (2014-07-30 13:52:52 UTC) #4
AKVT
On 2014/07/30 13:52:52, Ignacio Solla wrote: > On 2014/07/30 13:48:37, benm wrote: > > AwContents ...
6 years, 4 months ago (2014-07-30 13:54:47 UTC) #5
Ignacio Solla
On 2014/07/30 13:54:47, AKV wrote: > On 2014/07/30 13:52:52, Ignacio Solla wrote: > > On ...
6 years, 4 months ago (2014-07-30 14:08:52 UTC) #6
AKVT
The CQ bit was checked by ajith.v@samsung.com
6 years, 4 months ago (2014-07-30 14:10:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajith.v@samsung.com/421213004/1
6 years, 4 months ago (2014-07-30 14:10:40 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-07-30 15:22:30 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 15:24:52 UTC) #10
Message was sent while issue was closed.
Change committed as 286519

Powered by Google App Engine
This is Rietveld 408576698