chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

index 0f5ab105072d726d856b719d00d661c0d7a2892f..b0b9e1a4e4b116db0c78e12014832a3182f8d64d 100644

--- a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

@@ -207,8 +207,11 @@ void BookmarkAppBubbleView::WindowClosing() {

bookmark_app_bubble_ = NULL;

if (remove_app_) {

- GetExtensionService(profile_)->UninstallExtension(

- extension_id_, extensions::UNINSTALL_REASON_INSTALL_CANCELED, NULL);

+ GetExtensionService(profile_)

+ ->UninstallExtension(extension_id_,

+ extensions::UNINSTALL_REASON_INSTALL_CANCELED,

+ base::Bind(&base::DoNothing),

+ NULL);

} else {

ApplyEdits();

}