chrome/browser/ui/browser_browsertest.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index 4e85b9d6d89b494d896120b6f40a226b399c04d4..d51b6dc02db323ad0e2b639857640d1db3524942 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -1308,8 +1308,10 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_TabClosingWhenRemovingExtension) {

// Uninstall the extension and make sure TabClosing is sent.

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- service->UninstallExtension(

- GetExtension()->id(), extensions::UNINSTALL_REASON_FOR_TESTING, NULL);

+ service->UninstallExtension(GetExtension()->id(),

+ extensions::UNINSTALL_REASON_FOR_TESTING,

+ base::Bind(&base::DoNothing),

+ NULL);

EXPECT_EQ(1, observer.closing_count());

model->RemoveObserver(&observer);