chrome/browser/extensions/extension_service.h - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.h

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h

index 2aa60c054c9fe8561f4e1701cbe2f7af2caa8c67..43ae3974644f6edba6a3f2f36a3813ed85a06454 100644

--- a/chrome/browser/extensions/extension_service.h

+++ b/chrome/browser/extensions/extension_service.h

@@ -264,8 +264,12 @@ class ExtensionService

// Uninstalls the specified extension. Callers should only call this method

// with extensions that exist. |reason| lets the caller specify why the

// extension is uninstalled.

+ //

+ // If the return value is true, |deletion_done_callback| is invoked when data

+ // deletion is done or at least is scheduled.

virtual bool UninstallExtension(const std::string& extension_id,

extensions::UninstallReason reason,

+ const base::Closure& deletion_done_callback,

base::string16* error);

// Enables the extension. If the extension is already enabled, does