chrome/browser/apps/ephemeral_app_service.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_service.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_service.cc

diff --git a/chrome/browser/apps/ephemeral_app_service.cc b/chrome/browser/apps/ephemeral_app_service.cc

index 0fbc007979c111fb2cb324f58864676ce208b571..6bbb8f3ddbdd875fa3b08a925f8260da02eaf60f 100644

--- a/chrome/browser/apps/ephemeral_app_service.cc

+++ b/chrome/browser/apps/ephemeral_app_service.cc

@@ -103,6 +103,7 @@ void EphemeralAppService::ClearCachedApps() {

service->UninstallExtension(

extension_id,

extensions::UNINSTALL_REASON_ORPHANED_EPHEMERAL_EXTENSION,

+ base::Bind(&base::DoNothing),

NULL);

}

@@ -238,7 +239,10 @@ void EphemeralAppService::GarbageCollectApps() {

continue;

service->UninstallExtension(

- *id, extensions::UNINSTALL_REASON_ORPHANED_EPHEMERAL_EXTENSION, NULL);

+ *id,

+ extensions::UNINSTALL_REASON_ORPHANED_EPHEMERAL_EXTENSION,

+ base::Bind(&base::DoNothing),

+ NULL);

}