Issue 42119: Have RenderWidgetHostViewGtk take ownership of its widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42119: Have RenderWidgetHostViewGtk take ownership of its widget. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Have RenderWidgetHostViewGtk take ownership of its widget. We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy(). BUG=8707

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

TBR I'm hoping this will make the startup_tests start passing again. I will follow up ...

11 years, 9 months ago (2009-03-12 13:02:06 UTC) #1

Makes sense.

Expand Messages | Collapse Messages