Issue 421173003: base: Remove now-unused MessagePumpObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421173003: base: Remove now-unused MessagePumpObserver. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

base: Remove now-unused MessagePumpObserver. Jankometer is the last instance of a MessagePumpObserver. Since it has been removed, MessagePumpObserver can also be removed. BUG=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288203

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -91 lines)			Patch
M	base/BUILD.gn	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	base/message_loop/message_loop.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	base/message_loop/message_loop.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	base/message_loop/message_pump_observer.h	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	base/message_loop/message_pump_win.h	View		3 chunks	+0 lines, -15 lines	0 comments	Download
M	base/message_loop/message_pump_win.cc	View		3 chunks	+0 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

Assuming https://codereview.chromium.org/435603011/ goes through, this is ready for review.

6 years, 4 months ago (2014-08-07 00:28:03 UTC) #1

sadrul

6 years, 4 months ago (2014-08-08 01:48:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as 288203 (presubmit successful).