Paste PopupMenu gets cropped by StatusBar

content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.Context;
 import android.content.res.TypedArray;
 import android.util.TypedValue;
 import android.view.Gravity;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.view.ViewGroup.LayoutParams;
 import android.widget.PopupWindow;
 
 /**
  * Paste popup implementation based on TextView.PastePopupMenu.
  */
 public class PastePopupMenu implements OnClickListener {
     private final View mParent;
     private final PastePopupMenuDelegate mDelegate;
     private final Context mContext;
     private final PopupWindow mContainer;
     private int mRawPositionX;
     private int mRawPositionY;
     private int mPositionX;
     private int mPositionY;
+    private int mStatusBarHeight;
     private final View[] mPasteViews;
     private final int[] mPasteViewLayouts;
     private final int mLineOffsetY;
     private final int mWidthOffsetX;
 
     /**
      * Provider of paste functionality for the given popup.
      */
     public interface PastePopupMenuDelegate {
         /**
@@ skipping 34 matching lines @@
         for (int i = 0; i < attrs.length(); ++i) {
             mPasteViewLayouts[i] = attrs.getResourceId(attrs.getIndex(i), 0);
         }
         attrs.recycle();
 
         // Convert line offset dips to pixels.
         mLineOffsetY = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
                 5.0f, mContext.getResources().getDisplayMetrics());
         mWidthOffsetX = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
                 30.0f, mContext.getResources().getDisplayMetrics());
+        mStatusBarHeight = 0;

[jdduke (slow), 2014/07/30 15:24:16]

Nit: No need to initialize to 0, it will always be 0 upon creation (but please
keep a newline between the mWidthOffsetX assignment and the status bar height
calculation).

[kingshuk.j, 2014/07/31 04:40:04]

Done.

+        int resourceId = mContext.getResources()

[jdduke (slow), 2014/07/30 15:24:16]

Can we call this statusBarHeightResourceId?

[kingshuk.j, 2014/07/31 04:40:04]

Done.

+                .getIdentifier("status_bar_height", "dimen", "android");
+        if (resourceId > 0) {
+            mStatusBarHeight = mContext.getResources()
+                    .getDimensionPixelSize(resourceId);
+        }
     }
 
     /**
      * Shows the paste popup at an appropriate location relative to the specified position.
      */
     public void showAt(int x, int y) {
         if (!canPaste()) return;
         updateContent(true);
         positionAt(x, y);
     }
@@ skipping 30 matching lines @@
         int height = contentView.getMeasuredHeight();
 
         mPositionX = (int) (x - width / 2.0f);
         mPositionY = y - height - mLineOffsetY;
 
         final int[] coords = new int[2];
         mParent.getLocationInWindow(coords);
         coords[0] += mPositionX;
         coords[1] += mPositionY;
 
+        int statusBarHeight = 0;

[jdduke (slow), 2014/07/30 15:24:16]

Let's rename this to something like |minOffsetY|.

[kingshuk.j, 2014/07/31 04:40:04]

Done.

+        if (mParent.getSystemUiVisibility() == View.SYSTEM_UI_FLAG_VISIBLE) {
+            statusBarHeight = mStatusBarHeight;
+        }
+
         final int screenWidth = mContext.getResources().getDisplayMetrics().widthPixels;
-        if (coords[1] < 0) {
+        if (coords[1] < statusBarHeight) {
             updateContent(false);
             // Update dimensions from new view
             contentView = mContainer.getContentView();
             width = contentView.getMeasuredWidth();
             height = contentView.getMeasuredHeight();
 
             // Vertical clipping, move under edited line and to the side of insertion cursor
             // TODO bottom clipping in case there is no system bar
             coords[1] += height;
             coords[1] += mLineOffsetY;
@@ skipping 49 matching lines @@
     }
 
     private boolean canPaste() {
         return mDelegate.canPaste();
     }
 
     private void paste() {
         mDelegate.paste();
     }
 }