Paste PopupMenu gets cropped by StatusBar

content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.Context;
 import android.content.res.TypedArray;
 import android.util.TypedValue;
 import android.view.Gravity;
@@ skipping 113 matching lines @@
         int height = contentView.getMeasuredHeight();
 
         mPositionX = (int) (x - width / 2.0f);
         mPositionY = y - height - mLineOffsetY;
 
         final int[] coords = new int[2];
         mParent.getLocationInWindow(coords);
         coords[0] += mPositionX;
         coords[1] += mPositionY;
 
+        int statusBarHeight = 0;
+        int resourceId = mContext.getResources().getIdentifier("status_bar_height", "dimen", "android");

[jdduke (slow), 2014/07/28 15:46:03]

What guarantees do we have that the status bar will be visible? 

[kingshuk.j, 2014/07/29 11:09:27]

ok, I will put a check for the status bar visibility and upload.

+        if (resourceId > 0) {
+            statusBarHeight = mContext.getResources().getDimensionPixelSize(resourceId);
+        }
         final int screenWidth = mContext.getResources().getDisplayMetrics().widthPixels;
-        if (coords[1] < 0) {
+        if (coords[1] < statusBarHeight) {
             updateContent(false);
             // Update dimensions from new view
             contentView = mContainer.getContentView();
             width = contentView.getMeasuredWidth();
             height = contentView.getMeasuredHeight();
 
             // Vertical clipping, move under edited line and to the side of insertion cursor
             // TODO bottom clipping in case there is no system bar
             coords[1] += height;
             coords[1] += mLineOffsetY;
@@ skipping 49 matching lines @@
     }
 
     private boolean canPaste() {
         return mDelegate.canPaste();
     }
 
     private void paste() {
         mDelegate.paste();
     }
 }