test/cctest/cctest.h - Issue 421153002: fix StrDup memory leak in CcTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/cctest.h

Issue 421153002: fix StrDup memory leak in CcTest (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/cctest.h

diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h

index fc6ec398fd03a1464a9cb1e618b67612a17b72ff..00905978ece645283c50a0215b8d5a37a40a9367 100644

--- a/test/cctest/cctest.h

+++ b/test/cctest/cctest.h

@@ -98,6 +98,7 @@ class CcTest {

typedef void (TestFunction)();

CcTest(TestFunction* callback, const char* file, const char* name,

const char* dependency, bool enabled, bool initialize);

+ ~CcTest() { i::DeleteArray(file_); }

void Run();

static CcTest* last() { return last_; }

CcTest* prev() { return prev_; }

« no previous file with comments | « no previous file | no next file » | no next file with comments »