Don't leak visited site information from original profile to OTR profile....

chrome/common/visitedlink_common.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/visitedlink_common.h"
 
 #include "base/logging.h"
 #include "base/md5.h"
 
 const VisitedLinkCommon::Fingerprint VisitedLinkCommon::null_fingerprint_ = 0;
 const VisitedLinkCommon::Hash VisitedLinkCommon::null_hash_ = -1;
 
 VisitedLinkCommon::VisitedLinkCommon() :
     hash_table_(NULL),
     table_length_(0) {
 }
 
 VisitedLinkCommon::~VisitedLinkCommon() {
 }
 
 // FIXME: this uses linear probing, it should be replaced with quadratic
 // probing or something better. See VisitedLinkMaster::AddFingerprint
 bool VisitedLinkCommon::IsVisited(const char* canonical_url,
                                   size_t url_len) const {
   if (url_len == 0)
     return false;
-  if (!hash_table_ || table_length_ == 0) {
-    // Init() will always create a table, this means somebody forgot
-    NOTREACHED();
+  if (!hash_table_ || table_length_ == 0)
     return false;
-  }
   return IsVisited(ComputeURLFingerprint(canonical_url, url_len));
 }
 
 bool VisitedLinkCommon::IsVisited(Fingerprint fingerprint) const {
   // Go through the table until we find the item or an empty spot (meaning it
   // wasn't found). This loop will terminate as long as the table isn't full,
   // which should be enforced by AddFingerprint.
   Hash first_hash = HashFingerprint(fingerprint);
   Hash cur_hash = first_hash;
   while (true) {
@@ skipping 41 matching lines @@
   MD5Final(&digest, &ctx);
 
   // This is the same as "return *(Fingerprint*)&digest.a;" but if we do that
   // direct cast the alignment could be wrong, and we can't access a 64-bit int
   // on arbitrary alignment on some processors. This reinterpret_casts it
   // down to a char array of the same size as fingerprint, and then does the
   // bit cast, which amounts to a memcpy. This does not handle endian issues.
   return bit_cast<Fingerprint, uint8[8]>(
       *reinterpret_cast<uint8(*)[8]>(&digest.a));
 }