Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 421123003: DevTools: Suggest inspector reload after workspace mappings changes in settings. (Closed)

Created:
6 years, 4 months ago by vsevik
Modified:
6 years, 4 months ago
Reviewers:
dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Suggest inspector reload after workspace mappings changes in settings. BUG=357274 R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180158

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/devtools/front_end/settings/EditFileSystemDialog.js View 1 4 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
vsevik
PTAL
6 years, 4 months ago (2014-08-01 06:08:03 UTC) #1
dgozman
https://codereview.chromium.org/421123003/diff/1/Source/devtools/front_end/settings/EditFileSystemDialog.js File Source/devtools/front_end/settings/EditFileSystemDialog.js (right): https://codereview.chromium.org/421123003/diff/1/Source/devtools/front_end/settings/EditFileSystemDialog.js#newcode143 Source/devtools/front_end/settings/EditFileSystemDialog.js:143: if (window.confirm(WebInspector.UIString("It is recommended to restart inspector after making ...
6 years, 4 months ago (2014-08-01 10:34:10 UTC) #2
vsevik
Done, PTAL
6 years, 4 months ago (2014-08-01 13:21:59 UTC) #3
lushnikov
https://codereview.chromium.org/421123003/diff/20001/Source/devtools/front_end/settings/EditFileSystemDialog.js File Source/devtools/front_end/settings/EditFileSystemDialog.js (right): https://codereview.chromium.org/421123003/diff/20001/Source/devtools/front_end/settings/EditFileSystemDialog.js#newcode237 Source/devtools/front_end/settings/EditFileSystemDialog.js:237: this._hasMappingChanges = true; dont' we want to have these ...
6 years, 4 months ago (2014-08-04 09:52:23 UTC) #4
lushnikov
Do we want to land this?
6 years, 4 months ago (2014-08-11 09:45:14 UTC) #5
vsevik
> dont' we want to have these flags on in callbacks from > isolatedFileSystemManager? I.e. ...
6 years, 4 months ago (2014-08-11 12:17:31 UTC) #6
lushnikov
On 2014/08/11 12:17:31, vsevik wrote: > > dont' we want to have these flags on ...
6 years, 4 months ago (2014-08-12 09:47:04 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-13 07:40:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/421123003/20001
6 years, 4 months ago (2014-08-13 07:41:32 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 08:42:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 180158

Powered by Google App Engine
This is Rietveld 408576698