Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 42111: Get Linux layout_test archiving working with ssh. (Closed)

Created:
11 years, 9 months ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/slave/
Visibility:
Public.

Description

Get Linux layout_test archiving working with ssh. This depends on: http://codereview.chromium.org/42110 BUG=8483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11519

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M archive_layout_test_results.py View 1 1 chunk +9 lines, -3 lines 0 comments Download
M slave_utils.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Moss
11 years, 9 months ago (2009-03-12 04:13:14 UTC) #1
Nicolas Sylvain
LGTM with some modifications maybe if you change the path in the chromium_config file.
11 years, 9 months ago (2009-03-12 04:23:29 UTC) #2
Michael Moss
On 2009/03/12 04:23:29, Nicolas Sylvain wrote: > LGTM with some modifications maybe if you change ...
11 years, 9 months ago (2009-03-12 04:45:35 UTC) #3
M-A Ruel
11 years, 9 months ago (2009-03-12 11:20:05 UTC) #4
Add an assert on else fallback. lgtm beside this.

Powered by Google App Engine
This is Rietveld 408576698