Issue 42110: Support Linux build archiving with ssh transfers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42110: Support Linux build archiving with ssh transfers. (Closed)

Created:
11 years, 9 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/common/

Visibility:
Public.

Description

Support Linux build archiving with ssh transfers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11518

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	chromium_config.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chromium_utils.py	View		1 chunk	+38 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

LGTM http://codereview.chromium.org/42110/diff/1/3 File chromium_utils.py (right): http://codereview.chromium.org/42110/diff/1/3#newcode458 Line 458: command = ['ssh', host, 'mkdir', '-p', dest_path] ...

11 years, 9 months ago (2009-03-12 04:28:12 UTC) #2

M-A Ruel

11 years, 9 months ago (2009-03-12 11:02:22 UTC) #3

lgtm

http://codereview.chromium.org/42110/diff/1/3
File chromium_utils.py (right):

http://codereview.chromium.org/42110/diff/1/3#newcode474
Line 474: def SshCopyTree(srctree, host, dst):
So it takes 3 separate connections to do the whole thing. It'd had been nice if
we could reduce that, but that's not that bad.

Expand Messages | Collapse Messages