Issue 421043003: [NaCl SDK] Remove stubs for sitaddset/sigdelset and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421043003: [NaCl SDK] Remove stubs for sitaddset/sigdelset and friends. (Closed)

Created:
6 years, 4 months ago by Sam Clegg

Modified:
6 years, 4 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Remove stubs for sitaddset/sigdelset and friends. These stubs were included in the newlib case only but newlib contains these functions already in lib_a-sigset.o. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286882

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -69 lines)			Patch
M	native_client_sdk/src/libraries/nacl_io/library.dsc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
D	native_client_sdk/src/libraries/nacl_io/syscalls/sigaddset.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	native_client_sdk/src/libraries/nacl_io/syscalls/sigdelset.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	native_client_sdk/src/libraries/nacl_io/syscalls/sigemptyset.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	native_client_sdk/src/libraries/nacl_io/syscalls/sigfillset.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	native_client_sdk/src/libraries/nacl_io/syscalls/sigismember.c	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

binji

Not sure why I added these. Maybe they weren't in newlib until I rolled to ...

6 years, 4 months ago (2014-07-28 19:46:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/421043003/20001

6 years, 4 months ago (2014-07-31 19:34:48 UTC) #4

Message was sent while issue was closed.

Change committed as 286882

Expand Messages | Collapse Messages