Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 421003002: libwebp: update to 0.4.1 (Closed)

Created:
6 years, 5 months ago by jzern
Modified:
6 years, 3 months ago
Reviewers:
urvang (Google)
CC:
chromium-reviews, urvang (Google), jzern, skal, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

libwebp: update to 0.4.1 NEON performance improvements, aarch64 support BUG=354405, 374343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286366

Patch Set 1 #

Patch Set 2 : 0.4.1-final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11867 lines, -5366 lines) Patch
M third_party/libwebp/BUILD.gn View 1 6 chunks +19 lines, -6 lines 0 comments Download
M third_party/libwebp/README.chromium View 1 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/libwebp/dec/alpha.c View 1 5 chunks +13 lines, -9 lines 0 comments Download
M third_party/libwebp/dec/buffer.c View 1 4 chunks +55 lines, -14 lines 0 comments Download
M third_party/libwebp/dec/frame.c View 1 7 chunks +16 lines, -6 lines 0 comments Download
M third_party/libwebp/dec/idec.c View 1 13 chunks +46 lines, -44 lines 0 comments Download
M third_party/libwebp/dec/io.c View 1 19 chunks +60 lines, -40 lines 0 comments Download
D third_party/libwebp/dec/layer.c View 1 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/libwebp/dec/tree.c View 1 3 chunks +25 lines, -3 lines 0 comments Download
M third_party/libwebp/dec/vp8.c View 1 11 chunks +15 lines, -60 lines 0 comments Download
M third_party/libwebp/dec/vp8i.h View 1 6 chunks +7 lines, -12 lines 0 comments Download
M third_party/libwebp/dec/vp8l.c View 1 25 chunks +63 lines, -52 lines 0 comments Download
M third_party/libwebp/dec/vp8li.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/libwebp/dec/webp.c View 1 10 chunks +25 lines, -11 lines 0 comments Download
M third_party/libwebp/dec/webpi.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/libwebp/demux/demux.c View 1 11 chunks +13 lines, -13 lines 0 comments Download
A + third_party/libwebp/dsp/alpha_processing.c View 1 5 chunks +118 lines, -16 lines 0 comments Download
M third_party/libwebp/dsp/cpu.c View 1 4 chunks +52 lines, -2 lines 0 comments Download
M third_party/libwebp/dsp/dec.c View 1 13 chunks +53 lines, -78 lines 0 comments Download
A third_party/libwebp/dsp/dec_clip_tables.c View 1 1 chunk +366 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/dec_mips32.c View 1 1 chunk +578 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/dec_neon.c View 1 7 chunks +1008 lines, -149 lines 0 comments Download
M third_party/libwebp/dsp/dec_sse2.c View 1 20 chunks +274 lines, -252 lines 0 comments Download
M third_party/libwebp/dsp/dsp.h View 1 8 chunks +73 lines, -25 lines 0 comments Download
M third_party/libwebp/dsp/enc.c View 1 6 chunks +39 lines, -51 lines 0 comments Download
A + third_party/libwebp/dsp/enc_avx2.c View 1 2 chunks +9 lines, -15 lines 0 comments Download
A third_party/libwebp/dsp/enc_mips32.c View 1 1 chunk +767 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/enc_neon.c View 1 8 chunks +562 lines, -133 lines 0 comments Download
M third_party/libwebp/dsp/enc_sse2.c View 1 14 chunks +100 lines, -75 lines 0 comments Download
M third_party/libwebp/dsp/lossless.h View 1 3 chunks +86 lines, -53 lines 0 comments Download
M third_party/libwebp/dsp/lossless.c View 1 31 chunks +530 lines, -432 lines 0 comments Download
A third_party/libwebp/dsp/lossless_mips32.c View 1 1 chunk +416 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/lossless_neon.c View 1 1 chunk +332 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/lossless_sse2.c View 1 1 chunk +535 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/neon.h View 1 1 chunk +82 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/upsampling.c View 1 3 chunks +7 lines, -151 lines 0 comments Download
M third_party/libwebp/dsp/upsampling_neon.c View 1 6 chunks +29 lines, -27 lines 0 comments Download
M third_party/libwebp/dsp/upsampling_sse2.c View 1 3 chunks +13 lines, -17 lines 0 comments Download
M third_party/libwebp/dsp/yuv.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/libwebp/dsp/yuv.c View 1 2 chunks +79 lines, -132 lines 0 comments Download
A third_party/libwebp/dsp/yuv_mips32.c View 1 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/yuv_sse2.c View 1 1 chunk +322 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/yuv_tables_sse2.h View 1 1 chunk +536 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/alpha.c View 1 11 chunks +17 lines, -13 lines 0 comments Download
M third_party/libwebp/enc/analysis.c View 1 9 chunks +22 lines, -25 lines 0 comments Download
M third_party/libwebp/enc/backward_references.h View 1 1 chunk +77 lines, -17 lines 0 comments Download
M third_party/libwebp/enc/backward_references.c View 1 24 chunks +289 lines, -208 lines 0 comments Download
M third_party/libwebp/enc/config.c View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/cost.h View 1 2 chunks +32 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/cost.c View 1 2 chunks +248 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/filter.c View 1 5 chunks +7 lines, -182 lines 0 comments Download
M third_party/libwebp/enc/frame.c View 1 12 chunks +44 lines, -258 lines 0 comments Download
M third_party/libwebp/enc/histogram.h View 1 4 chunks +27 lines, -10 lines 0 comments Download
M third_party/libwebp/enc/histogram.c View 1 12 chunks +475 lines, -246 lines 0 comments Download
D third_party/libwebp/enc/layer.c View 1 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/libwebp/enc/picture.c View 1 5 chunks +109 lines, -1144 lines 0 comments Download
A third_party/libwebp/enc/picture_csp.c View 1 1 chunk +395 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/picture_psnr.c View 1 1 chunk +150 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/picture_rescale.c View 1 1 chunk +285 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/picture_tools.c View 1 1 chunk +206 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/quant.c View 1 14 chunks +133 lines, -119 lines 0 comments Download
M third_party/libwebp/enc/syntax.c View 1 3 chunks +10 lines, -50 lines 0 comments Download
M third_party/libwebp/enc/token.c View 1 6 chunks +33 lines, -20 lines 0 comments Download
M third_party/libwebp/enc/vp8enci.h View 1 9 chunks +35 lines, -23 lines 0 comments Download
M third_party/libwebp/enc/vp8l.c View 1 32 chunks +249 lines, -173 lines 0 comments Download
M third_party/libwebp/enc/vp8li.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/webpenc.c View 1 7 chunks +23 lines, -53 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 6 chunks +16 lines, -3 lines 0 comments Download
D third_party/libwebp/utils/alpha_processing.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/libwebp/utils/alpha_processing.c View 1 1 chunk +0 lines, -196 lines 0 comments Download
M third_party/libwebp/utils/bit_reader.h View 1 3 chunks +35 lines, -215 lines 0 comments Download
M third_party/libwebp/utils/bit_reader.c View 1 7 chunks +64 lines, -52 lines 0 comments Download
A third_party/libwebp/utils/bit_reader_inl.h View 1 1 chunk +171 lines, -0 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.h View 1 1 chunk +25 lines, -30 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.c View 1 7 chunks +75 lines, -50 lines 0 comments Download
M third_party/libwebp/utils/color_cache.c View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/libwebp/utils/endian_inl.h View 1 1 chunk +102 lines, -0 lines 0 comments Download
M third_party/libwebp/utils/huffman.h View 1 3 chunks +27 lines, -12 lines 0 comments Download
M third_party/libwebp/utils/huffman.c View 1 6 chunks +63 lines, -32 lines 0 comments Download
M third_party/libwebp/utils/huffman_encode.h View 1 1 chunk +14 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/huffman_encode.c View 1 10 chunks +27 lines, -50 lines 0 comments Download
M third_party/libwebp/utils/quant_levels_dec.h View 1 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/quant_levels_dec.c View 1 1 chunk +261 lines, -6 lines 0 comments Download
M third_party/libwebp/utils/random.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libwebp/utils/rescaler.h View 1 1 chunk +7 lines, -9 lines 0 comments Download
M third_party/libwebp/utils/rescaler.c View 1 4 chunks +219 lines, -38 lines 0 comments Download
M third_party/libwebp/utils/thread.h View 1 3 chunks +43 lines, -47 lines 0 comments Download
M third_party/libwebp/utils/thread.c View 1 4 chunks +104 lines, -36 lines 0 comments Download
M third_party/libwebp/utils/utils.h View 1 2 chunks +40 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/utils.c View 1 1 chunk +172 lines, -3 lines 0 comments Download
M third_party/libwebp/webp/decode.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/libwebp/webp/encode.h View 1 5 chunks +30 lines, -20 lines 0 comments Download
M third_party/libwebp/webp/mux.h View 1 3 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jzern
The layout tests clear now with the fragile encode tests skipped, should be good to ...
6 years, 4 months ago (2014-07-29 19:40:42 UTC) #1
urvang (Google)
lgtm Sounds good. CQing..
6 years, 4 months ago (2014-07-29 20:21:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/421003002/10001
6 years, 4 months ago (2014-07-29 20:22:53 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 23:44:28 UTC) #4
commit-bot: I haz the power
Change committed as 286366
6 years, 4 months ago (2014-07-30 00:59:25 UTC) #5
Anton
6 years, 3 months ago (2014-09-12 10:57:24 UTC) #6
Message was sent while issue was closed. 
On 2014/07/30 00:59:25, I haz the power (commit-bot) wrote:
> Change committed as 286366

It looks like the compiler crashes dues to this change:
../../third_party/libwebp/dsp/enc_neon.c: In function 'DistoTranspose4x4':
../../third_party/libwebp/dsp/enc_neon.c:573:1: internal compiler error: in
simplify_const_unary_operation, at simplify-rtx.c:1539

https://chromegw.corp.google.com/i/chrome.mobile.official/builders/android-ar...

Not sure why this is only happening on official builder.

Powered by Google App Engine
This is Rietveld 408576698