Started on Resource class.

src/shared/ppapi_proxy/plugin_core.cc

 /*
  * Copyright 2010 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 #include "native_client/src/shared/ppapi_proxy/plugin_core.h"
 #include <stdio.h>
 #include <map>
 #include "native_client/src/include/nacl_macros.h"
 #include "native_client/src/include/portability.h"
 #include "gen/native_client/src/shared/ppapi_proxy/ppb_rpc.h"
 #include "native_client/src/shared/ppapi_proxy/plugin_globals.h"
+#include "native_client/src/shared/ppapi_proxy/plugin_resource_tracker.h"
 #include "native_client/src/shared/ppapi_proxy/utility.h"
 #include "ppapi/c/ppb_core.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/cpp/common.h"
 
 using ppapi_proxy::DebugPrintf;
 
 // All of the methods here are invoked from the plugin's main (UI) thread,
 // so no locking is done.
 
 namespace {
 #ifdef __native_client__
 __thread bool is_main_thread = false;
 bool main_thread_marked = false;
 #endif  // __native_client__
 
-std::map<PP_Resource, uint32_t>* local_ref_count;
-
-// Increment the reference count for a specified resource.  This is done with
-// a plugin-side cache, maintained by this helper function.  Only the first time
-// a resource has an AddRef call requires an RPC to the browser.
+// Increment the reference count for a specified resource.  This only takes
+// care of the plugin's reference count - the Resource should obtain the
+// browser reference when it stores the browser's Resource id. When the
+// Resource's reference count goes to zero, the destructor should make sure
+// the browser reference is returned.
 void AddRefResource(PP_Resource resource) {
   DebugPrintf("PluginCore::AddRefResource: resource=%"NACL_PRIu64"\n",
               resource);
-  if (local_ref_count == NULL) {
-    local_ref_count = new std::map<PP_Resource, uint32_t>;
-  }
-  if (local_ref_count->find(resource) == local_ref_count->end()) {
-    // The first time we create a local ref count object we need to increment
-    // the reference count in the browser.
-    NaClSrpcChannel* channel = ppapi_proxy::GetMainSrpcChannel();
-    (void) PpbCoreRpcClient::PPB_Core_AddRefResource(channel, resource);
-    // And add a local (cached) reference count object.
-    (*local_ref_count)[resource] = 1;
-    return;
-  } else {
-    // Otherwise, just update the local reference count.
-    (*local_ref_count)[resource] = (*local_ref_count)[resource] + 1;
-  }
+  if (ppapi_proxy::PluginResourceTracker::Get()->AddRefResource(resource))
+    DebugPrintf("Warning: AddRefResource()ing a nonexistent resource");
 }
 
 void ReleaseResource(PP_Resource resource) {
   DebugPrintf("PluginCore::ReleaseResource: resource=%"NACL_PRIu64"\n",
               resource);
-  if (local_ref_count == NULL ||
-      local_ref_count->find(resource) == local_ref_count->end()) {
-    // ERROR: How can we decrement if there is no local (cached) reference
-    // count for the specified resource?
-    return;
-  }
-  if ((*local_ref_count)[resource] > 1) {
-    // Just update the local (cached) reference count.
-    (*local_ref_count)[resource] = (*local_ref_count)[resource] - 1;
-    return;
-  } else {
-    // When the local reference count goes to zero we decrement the reference
-    // count in the browser.
-    NaClSrpcChannel* channel = ppapi_proxy::GetMainSrpcChannel();
-    (void) PpbCoreRpcClient::PPB_Core_ReleaseResource(channel, resource);
-    // Then remove the local reference count for the resource.
-    local_ref_count->erase(resource);
-    if (local_ref_count->size() == 0) {
-      // There are no locally reference counted objects, free the map.
-      delete local_ref_count;
-      local_ref_count = NULL;
-    }
-  }
+  if (ppapi_proxy::PluginResourceTracker::Get()->UnrefResource(resource))
+    DebugPrintf("Warning: ReleaseRefResource()ing a nonexistent resource");
 }
 
 void* MemAlloc(size_t num_bytes) {
   DebugPrintf("PluginCore::MemAlloc: num_bytes=%"NACL_PRIuS"\n", num_bytes);
   return malloc(num_bytes);
 }
 
 void MemFree(void* ptr) {
   DebugPrintf("PluginCore::MemFree: ptr=%p\n", ptr);
   free(ptr);
@@ skipping 75 matching lines @@
     // Setting this once works because the main thread will call this function
     // before calling any pthread_creates.  Hence the result is already
     // published before other threads might attempt to call it.
     main_thread_marked = true;
   }
 #endif  // __native_client__
 }
 
 
 }  // namespace ppapi_proxy