Issue 420883003: Desupport AES-192 in crypto::SymmetricKey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420883003: Desupport AES-192 in crypto::SymmetricKey. (Closed)

Created:
6 years, 5 months ago by davidben

Modified:
6 years, 5 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Desupport AES-192 in crypto::SymmetricKey. BoringSSL does not support AES-192. No current consumer uses AES-192, so remove the test which asserts it works. This fixes crypto_unittests in the Mac OpenSSL port. Blacklist AES-192 in the NSS implementation so that we do not accidentally grow a new dependency on it. BUG=338885 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285678

Patch Set 1 #

Patch Set 2 : Missed a spot #

Patch Set 3 : Whitelist rather than blacklist #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -27 lines)			Patch
M	crypto/encryptor_unittest.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	crypto/symmetric_key_nss.cc	View	1 2	3 chunks	+22 lines, -1 line	0 comments	Download
M	crypto/symmetric_key_openssl.cc	View	1 2	3 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Feels like it'd be better to whitelist key sizes, in both _openssl and _nss, but ...

6 years, 5 months ago (2014-07-25 18:50:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/420883003/30003

6 years, 5 months ago (2014-07-25 19:36:43 UTC) #6

Message was sent while issue was closed.

Change committed as 285678

Expand Messages | Collapse Messages