Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 420793003: MIPS: CallIC customization stubs must accept that a vector slot is cleared. (Closed)

Created:
6 years, 4 months ago by balazs.kilvady
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: CallIC customization stubs must accept that a vector slot is cleared. Port r22668 (7be1212) Original commit message: The CallIC Array custom IC stub read from the type vector, expecting to get an AllocationSite. But there are paths in the system where a type vector can be re-created with default values, even though we currently grant an exception to clearing of vector slots with AllocationSites in them at gc time. BUG=392114 LOG=N R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22683

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
balazs.kilvady
6 years, 4 months ago (2014-07-29 18:36:31 UTC) #1
paul.l...
LGTM, but please fix the nit when landing. https://codereview.chromium.org/420793003/diff/1/src/mips64/code-stubs-mips64.cc File src/mips64/code-stubs-mips64.cc (right): https://codereview.chromium.org/420793003/diff/1/src/mips64/code-stubs-mips64.cc#newcode3176 src/mips64/code-stubs-mips64.cc:3176: // ...
6 years, 4 months ago (2014-07-29 19:25:56 UTC) #2
balazs.kilvady
https://codereview.chromium.org/420793003/diff/1/src/mips64/code-stubs-mips64.cc File src/mips64/code-stubs-mips64.cc (right): https://codereview.chromium.org/420793003/diff/1/src/mips64/code-stubs-mips64.cc#newcode3176 src/mips64/code-stubs-mips64.cc:3176: // Verify that r4 contains an AllocationSite On 2014/07/29 ...
6 years, 4 months ago (2014-07-29 19:35:28 UTC) #3
balazs.kilvady
6 years, 4 months ago (2014-07-29 19:36:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698