Issue 420783002: DevTools: Make WI.Target.Capabilities enum values uppercase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420783002: DevTools: Make WI.Target.Capabilities enum values uppercase (Closed)

Created:
6 years, 5 months ago by apavlov

Modified:
6 years, 5 months ago

Reviewers:
sergeyv

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Make WI.Target.Capabilities enum values uppercase We've got all enum values starting with an uppercase letter in our code TBR=sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178924

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	Source/devtools/front_end/main/ScreencastApp.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/OverridesSupport.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/Target.js	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePowerOverview.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/420783002/1

6 years, 5 months ago (2014-07-25 09:56:33 UTC) #3

Message was sent while issue was closed.

Change committed as 178924

Expand Messages | Collapse Messages