Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_dictionary.py
diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py
index c9fd904a9e40a735cd075a397bbefb316506c1ff..3937b3f7076a68652037790c5d70b73e8d2124af 100644
--- a/Source/bindings/scripts/v8_dictionary.py
+++ b/Source/bindings/scripts/v8_dictionary.py
@@ -28,7 +28,7 @@ def setter_name_for_dictionary_member(member):
return 'set%s' % v8_utilities.capitalize(member.name)
-def has_name_for_dictionary_member(member):
+def has_method_name_for_dictionary_member(member):
return 'has%s' % v8_utilities.capitalize(member.name)
@@ -79,11 +79,58 @@ def member_context(member):
cpp_value='impl->%s()' % member.name, isolate='isolate',
creation_context='creationContext',
extended_attributes=member.extended_attributes),
- 'has_name': has_name_for_dictionary_member(member),
+ 'has_method_name': has_method_name_for_dictionary_member(member),
'name': member.name,
'setter_name': setter_name_for_dictionary_member(member),
'v8_default_value': v8_default_value,
'v8_type': v8_types.v8_type(idl_type.base_type),
}
-# FIXME: Implement context for impl class.
+
+# Context for implementation classes
+
+def dictionary_impl_context(dictionary, interfaces_info):
+ includes.clear()
+ header_includes = set(['platform/heap/Handle.h'])
+ return {
+ 'header_includes': header_includes,
+ 'cpp_class': v8_utilities.cpp_name(dictionary),
+ 'members': [member_impl_context(member, interfaces_info,
+ header_includes)
+ for member in dictionary.members],
+ }
+
+
+def member_impl_context(member, interfaces_info, header_includes):
+ idl_type = member.idl_type
+
+ def getter_expression():
+ if idl_type.impl_should_use_nullable_container:
+ return 'm_%s.get()' % member.name
+ return 'm_%s' % member.name
+
+ def has_method_expression():
+ if (idl_type.impl_should_use_nullable_container or
+ idl_type.is_string_type):
+ return '!m_%s.isNull()' % member.name
+ else:
+ return 'm_%s' % member.name
+
+ def member_cpp_type():
+ member_cpp_type = idl_type.cpp_type_args(used_in_cpp_sequence=True)
+ if idl_type.impl_should_use_nullable_container:
+ return v8_types.cpp_template_type('Nullable', member_cpp_type)
+ return member_cpp_type
+
+ header_includes.update(idl_type.impl_includes_for_type(interfaces_info))
+ return {
+ 'getter_expression': getter_expression(),
+ 'has_method_expression': has_method_expression(),
+ 'has_method_name': has_method_name_for_dictionary_member(member),
+ 'is_traceable': (idl_type.is_garbage_collected or
+ idl_type.is_will_be_garbage_collected),
+ 'member_cpp_type': member_cpp_type(),
+ 'name': member.name,
+ 'rvalue_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True),
+ 'setter_name': setter_name_for_dictionary_member(member),
+ }

Powered by Google App Engine
This is Rietveld 408576698