Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: Source/bindings/tests/results/V8TestDictionary.cpp

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestDictionary.cpp
diff --git a/Source/bindings/tests/results/V8TestDictionary.cpp b/Source/bindings/tests/results/V8TestDictionary.cpp
index 002661dde6ab6501c41b6750be57e344ed5874a3..384749ae178d0066898a230a7031c9081983a9fe 100644
--- a/Source/bindings/tests/results/V8TestDictionary.cpp
+++ b/Source/bindings/tests/results/V8TestDictionary.cpp
@@ -29,6 +29,9 @@ TestDictionary* V8TestDictionary::toNative(v8::Isolate* isolate, v8::Handle<v8::
impl->setLongMember(longMember);
else
impl->setLongMember(1);
+ Vector<String> stringArrayMember;
+ if (DictionaryHelper::get(dictionary, "stringArrayMember", stringArrayMember))
+ impl->setStringArrayMember(stringArrayMember);
String stringMember;
if (DictionaryHelper::get(dictionary, "stringMember", stringMember))
impl->setStringMember(stringMember);
@@ -37,6 +40,9 @@ TestDictionary* V8TestDictionary::toNative(v8::Isolate* isolate, v8::Handle<v8::
impl->setStringOrNullMember(stringOrNullMember);
else
impl->setStringOrNullMember(String("default string value"));
+ Vector<String> stringSequenceMember;
+ if (DictionaryHelper::get(dictionary, "stringSequenceMember", stringSequenceMember))
+ impl->setStringSequenceMember(stringSequenceMember);
RefPtr<TestInterfaceImplementation> testInterfaceMember;
if (DictionaryHelper::get(dictionary, "testInterfaceMember", testInterfaceMember))
impl->setTestInterfaceMember(testInterfaceMember);
@@ -59,12 +65,16 @@ v8::Handle<v8::Value> toV8(TestDictionary* impl, v8::Handle<v8::Object> creation
v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, impl->longMember()));
else
v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, 1));
+ if (impl->hasStringArrayMember())
+ v8Object->Set(v8String(isolate, "stringArrayMember"), v8Array(impl->stringArrayMember(), creationContext, isolate));
if (impl->hasStringMember())
v8Object->Set(v8String(isolate, "stringMember"), v8String(isolate, impl->stringMember()));
if (impl->hasStringOrNullMember())
v8Object->Set(v8String(isolate, "stringOrNullMember"), impl->stringOrNullMember().isNull() ? v8::Handle<v8::Value>(v8::Null(isolate)) : v8String(isolate, impl->stringOrNullMember()));
else
v8Object->Set(v8String(isolate, "stringOrNullMember"), v8String(isolate, String("default string value")));
+ if (impl->hasStringSequenceMember())
+ v8Object->Set(v8String(isolate, "stringSequenceMember"), v8Array(impl->stringSequenceMember(), creationContext, isolate));
if (impl->hasTestInterfaceMember())
v8Object->Set(v8String(isolate, "testInterfaceMember"), toV8(impl->testInterfaceMember(), creationContext, isolate));
if (impl->hasTestInterfaceOrNullMember())

Powered by Google App Engine
This is Rietveld 408576698