Source/bindings/tests/idls/TestDictionary.idl - Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestDictionary.idl

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/dictionary_impl.h ('K') | « Source/bindings/templates/templates.gypi ('k') | Source/bindings/tests/results/TestDictionary.h » ('j') | Source/bindings/tests/results/TestDictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestDictionary.idl

diff --git a/Source/bindings/tests/idls/TestDictionary.idl b/Source/bindings/tests/idls/TestDictionary.idl

index 3837db23e00eb292f6bd7d809d212eb3a2c9a80c..129355b7176d2398ba316f4a4f95ea923fd423d9 100644

--- a/Source/bindings/tests/idls/TestDictionary.idl

+++ b/Source/bindings/tests/idls/TestDictionary.idl

@@ -11,4 +11,6 @@

double? doubleOrNullMember = null;

DOMString? stringOrNullMember = "default string value";

TestInterface? testInterfaceOrNullMember;

haraken 2014/07/27 07:46:36 Would you add test cases for: TestInterfaceGarbag

bashi 2014/07/29 03:52:51 Done.

+ DOMString[] stringArrayMember;

+ sequence<DOMString> stringSequenceMember;

haraken 2014/07/27 07:46:36 Just help me understand: What's the difference bet

bashi 2014/07/29 03:52:51 In terms of the spec, sequence<T> is passed by val

};