Source/bindings/tests/idls/TestDictionary.idl - Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/tests/idls/TestDictionary.idl

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/templates/dictionary_impl.h ('K') | « Source/bindings/templates/templates.gypi ('k') | Source/bindings/tests/results/TestDictionary.h » ('j') | Source/bindings/tests/results/TestDictionary.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 [	4 [

5 GarbageCollected,	5 GarbageCollected,

6 ] dictionary TestDictionary {	6 ] dictionary TestDictionary {

7 boolean booleanMember;	7 boolean booleanMember;

8 long longMember = 1;	8 long longMember = 1;

9 DOMString stringMember;	9 DOMString stringMember;

10 TestInterface testInterfaceMember;	10 TestInterface testInterfaceMember;

11 double? doubleOrNullMember = null;	11 double? doubleOrNullMember = null;

12 DOMString? stringOrNullMember = "default string value";	12 DOMString? stringOrNullMember = "default string value";

13 TestInterface? testInterfaceOrNullMember;	13 TestInterface? testInterfaceOrNullMember;
	haraken 2014/07/27 07:46:36 Would you add test cases for: TestInterfaceGarbag Would you add test cases for: TestInterfaceGarbageCollected testInterfaceGarbageCollectedMember; TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNullMember; TestInterfaceWillBeGarbageCollected testInterfaceWillBeGarbageCollectedMember; TestInterfaceWillBeGarbageCollected? testInterfaceWillBeGarbageCollectedOrNullMember; These members needs to be traced in the trace() method. bashi 2014/07/29 03:52:51 Done. Show quoted text On 2014/07/27 07:46:36, haraken wrote: > > Would you add test cases for: > > TestInterfaceGarbageCollected testInterfaceGarbageCollectedMember; > TestInterfaceGarbageCollected? testInterfaceGarbageCollectedOrNullMember; > TestInterfaceWillBeGarbageCollected testInterfaceWillBeGarbageCollectedMember; > TestInterfaceWillBeGarbageCollected? > testInterfaceWillBeGarbageCollectedOrNullMember; > > These members needs to be traced in the trace() method. Done.
	14 DOMString[] stringArrayMember;

	15 sequence<DOMString> stringSequenceMember;
	haraken 2014/07/27 07:46:36 Just help me understand: What's the difference bet Just help me understand: What's the difference between DOMString[] and sequence<DOMString>? bashi 2014/07/29 03:52:51 In terms of the spec, sequence<T> is passed by val Show quoted text On 2014/07/27 07:46:36, haraken wrote: > > Just help me understand: What's the difference between DOMString[] and > sequence<DOMString>? In terms of the spec, sequence<T> is passed by value, and T[] is passed by reference. However, it seems that we don't much care about the difference in the code generator. We may need to investigate if this is a problem.
14 };	16 };

OLD	NEW