chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 420713003: Translate: Don't show 'Translated' bubble when the user dismisses the bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 420713003: Translate: Don't show 'Translated' bubble when the user dismisses the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cocoa Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index b1571823b070f5bbbe550c54670b1370fde6cbae..200b0012d148b50c393ee025eea9b644b52b2a90 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -495,7 +495,8 @@ void BrowserWindowCocoa::ShowBookmarkAppBubble(

void BrowserWindowCocoa::ShowTranslateBubble(

content::WebContents* contents,

translate::TranslateStep step,

- translate::TranslateErrors::Type error_type) {

+ translate::TranslateErrors::Type error_type,

+ bool is_user_gesture) {

ChromeTranslateClient* chrome_translate_client =

ChromeTranslateClient::FromWebContents(contents);

translate::LanguageState& language_state =

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/translate/translate_bubble_factory.cc » ('j') | no next file with comments »