Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6077)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 420713003: Translate: Don't show 'Translated' bubble when the user dismisses the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index a22b4dadd9e599a90fbf497cde8afdb99e5c8592..bb1e070e039e8fac5df432d16a0fe4da6a682745 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -83,7 +83,8 @@ TranslateBubbleView::~TranslateBubbleView() {
void TranslateBubbleView::ShowBubble(views::View* anchor_view,
content::WebContents* web_contents,
translate::TranslateStep step,
- TranslateErrors::Type error_type) {
+ TranslateErrors::Type error_type,
+ bool is_explicit) {
if (IsShowing()) {
// When the user reads the advanced setting panel, the bubble should not be
// changed because he/she is focusing on the bubble.
@@ -100,6 +101,11 @@ void TranslateBubbleView::ShowBubble(views::View* anchor_view,
translate_bubble_view_->SwitchToErrorView(error_type);
}
return;
+ } else {
+ if (step == translate::TRANSLATE_STEP_AFTER_TRANSLATE &&
+ !is_explicit) {
+ return;
+ }
}
std::string source_language;

Powered by Google App Engine
This is Rietveld 408576698