chrome/browser/ui/views/frame/browser_view.cc - Issue 420713003: Translate: Don't show 'Translated' bubble when the user dismisses the bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 420713003: Translate: Don't show 'Translated' bubble when the user dismisses the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/translate/translate_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 127722367afce5cc74b9e9bd949985aaa5f40baa..0be54f9bfdc96f930d61e211c3138d7d61462f61 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1158,7 +1158,8 @@ void BrowserView::ShowBookmarkAppBubble(

void BrowserView::ShowTranslateBubble(content::WebContents* web_contents,

translate::TranslateStep step,

- TranslateErrors::Type error_type) {

+ TranslateErrors::Type error_type,

+ bool is_explicit) {

if (contents_web_view_->HasFocus() &&

!GetLocationBarView()->IsMouseHovered()) {

content::RenderViewHost* rvh = web_contents->GetRenderViewHost();

@@ -1176,7 +1177,7 @@ void BrowserView::ShowTranslateBubble(content::WebContents* web_contents,

TranslateBubbleView::ShowBubble(

GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,

- error_type);

+ error_type, is_explicit);

}

#if defined(ENABLE_ONE_CLICK_SIGNIN)