Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 420713002: Move the serial api and permission features to extensions/. (Closed)

Created:
6 years, 5 months ago by Sam McNally
Modified:
6 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the serial api and permission features to extensions/. BUG=389016 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285861

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam McNally
6 years, 5 months ago (2014-07-25 07:38:27 UTC) #1
benwells
lgtm
6 years, 4 months ago (2014-07-28 03:24:22 UTC) #2
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 4 months ago (2014-07-28 03:25:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/420713002/60001
6 years, 4 months ago (2014-07-28 03:26:58 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 04:39:30 UTC) #5
Message was sent while issue was closed.
Change committed as 285861

Powered by Google App Engine
This is Rietveld 408576698