Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: pkg/polymer/test/publish_inherited_properties_test.dart

Issue 420673002: Roll polymer packages to version 0.3.4 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/test/computed_properties_test.html ('k') | pkg/polymer/test/unbind_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/publish_inherited_properties_test.dart
diff --git a/pkg/polymer/test/publish_inherited_properties_test.dart b/pkg/polymer/test/publish_inherited_properties_test.dart
index e9002439216a904f8ce727e6cbb0d5ebeba37c74..583f8cd127cd9e8f0e6ced5b86c21e381103b757 100644
--- a/pkg/polymer/test/publish_inherited_properties_test.dart
+++ b/pkg/polymer/test/publish_inherited_properties_test.dart
@@ -6,6 +6,7 @@ import 'dart:html';
import 'package:unittest/unittest.dart';
import 'package:unittest/html_config.dart';
import 'package:polymer/polymer.dart';
+import 'package:logging/logging.dart';
// Dart note: unlike JS, you can't publish something that doesn't
// have a corresponding field because we can't dynamically add properties.
@@ -26,16 +27,20 @@ class XBar extends XFoo {
class XZot extends XBar {
XZot.created() : super.created();
+ // Note: this is published because it appears in the `attributes` attribute.
var m;
+
@published int zot = 3;
}
-// TODO(sigmund): uncomment this part of the test too (see dartbug.com/14559)
-// class XWho extends XZot {
-// XWho.created() : super.created();
-//
-// @published var zap;
-// }
+// Regresion test for dartbug.comk/14559. The bug is still open, but we don't
+// hit it now that we use smoke. The bug was assinging @CustomTag('x-zot') to
+// this class incorrectly and as a result `zap` was listed in `x-zot`.
+class XWho extends XZot {
+ XWho.created() : super.created();
+
+ @published var zap;
+}
@CustomTag('x-squid')
class XSquid extends XZot {
@@ -47,11 +52,13 @@ class XSquid extends XZot {
}
main() => initPolymer().run(() {
+ Logger.root.level = Level.ALL;
+ Logger.root.onRecord.listen((r) => print('${r.loggerName} ${r.message}'));
useHtmlConfiguration();
- setUp(() => Polymer.onReady.then((_) {
- Polymer.register('x-noscript', XZot);
- }));
+ Polymer.register('x-noscript', XZot);
+
+ setUp(() => Polymer.onReady);
test('published properties', () {
published(tag) => (new Element.tag(tag) as PolymerElement)
@@ -60,7 +67,6 @@ main() => initPolymer().run(() {
expect(published('x-zot'), ['Foo', 'Bar', 'zot', 'm']);
expect(published('x-squid'), ['Foo', 'Bar', 'zot', 'm', 'baz', 'squid']);
expect(published('x-noscript'), ['Foo', 'Bar', 'zot', 'm']);
- // TODO(sigmund): uncomment, see above
- // expect(published('x-squid'), [#Foo, #Bar, #zot, #zap, #baz, #squid]);
+ expect(published('x-squid'), ['Foo', 'Bar', 'zot', 'm', 'baz', 'squid']);
});
});
« no previous file with comments | « pkg/polymer/test/computed_properties_test.html ('k') | pkg/polymer/test/unbind_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698