Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 420663004: Make athena_unittests pass if the chrome executable is not built (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make athena_unittests pass if the chrome executable is not built BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285703

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M athena/main/athena_main.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_shell.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M athena/test/athena_unittests.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
Oshima, PTAL ash_unittests passes if chrome is not built even though it uses InitSharedInstanceWithLocale() because ...
6 years, 4 months ago (2014-07-25 02:46:26 UTC) #1
pkotwicz
Oshima, PTAL ash_unittests passes if chrome is not built even though it uses InitSharedInstanceWithLocale() because ...
6 years, 4 months ago (2014-07-25 02:47:44 UTC) #2
oshima
On 2014/07/25 02:47:44, pkotwicz wrote: > Oshima, PTAL > > ash_unittests passes if chrome is ...
6 years, 4 months ago (2014-07-25 16:41:20 UTC) #3
pkotwicz
Yes, you are right it should. I have made the athena_shell target use athena_resouces.pak too
6 years, 4 months ago (2014-07-25 17:39:40 UTC) #4
oshima
lgtm
6 years, 4 months ago (2014-07-25 19:37:33 UTC) #5
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-07-25 19:41:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/420663004/20001
6 years, 4 months ago (2014-07-25 19:43:13 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 22:05:57 UTC) #8
Message was sent while issue was closed.
Change committed as 285703

Powered by Google App Engine
This is Rietveld 408576698