Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 420663003: Extensions: Move bluetooth APIs to extensions/. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook, tfarina, rpaquay
Project:
chromium
Visibility:
Public.

Description

Extensions: Move bluetooth APIs to extensions/. BUG=395240 TBR=keybuk@chromium.org Committed: https://crrev.com/8146daf0a5a91e4bedec34cfe0b942803c36aa90 Cr-Commit-Position: refs/heads/master@{#292719}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : fix build #

Patch Set 4 : fix android, gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -10847 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_pairing_delegate.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_pairing_delegate.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_utils.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_utils.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 1 chunk +0 lines, -459 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 1 chunk +0 lines, -367 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_private_api.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc View 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_private_apitest.cc View 1 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.h View 1 chunk +0 lines, -337 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 1 chunk +0 lines, -773 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 chunk +0 lines, -1283 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_connection.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_connection.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 1 chunk +0 lines, -416 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 1 1 chunk +0 lines, -1450 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/utils.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_low_energy/utils.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_api_socket.h View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_api_socket.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h View 1 1 chunk +0 lines, -352 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc View 1 1 chunk +0 lines, -678 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc View 1 chunk +0 lines, -372 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/bluetooth.idl View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_data.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_data.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_handler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_handler.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/common/extensions/api/bluetooth_low_energy.idl View 1 chunk +0 lines, -299 lines 0 comments Download
D chrome/common/extensions/api/bluetooth_private.json View 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/common/extensions/api/bluetooth_socket.idl View 1 chunk +0 lines, -316 lines 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/api_resource_manager.h View 2 chunks +3 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api_pairing_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api_pairing_delegate.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api_utils.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_api_utils.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_event_router.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_event_router.cc View 3 chunks +9 lines, -9 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_extension_function.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_extension_function.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_private_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_private_api.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/browser/api/bluetooth/bluetooth_private_apitest.cc View 1 6 chunks +16 lines, -13 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 9 chunks +16 lines, -14 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/utils.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth_low_energy/utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_api_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc View 1 4 chunks +14 lines, -14 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M extensions/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/common/api/bluetooth.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_permission.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/api/bluetooth/bluetooth_manifest_permission.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + extensions/common/api/bluetooth_low_energy.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/common/api/bluetooth_private.json View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/api/bluetooth_socket.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/extensions_manifest_types.json View 1 chunk +26 lines, -0 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 6 chunks +43 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Lei Zhang
PTAL, no rush.
6 years, 4 months ago (2014-08-21 22:25:55 UTC) #1
Ken Rockot(use gerrit already)
Haven't reviewed yet, just CCing some folks for FYI because I found a relevant conversation ...
6 years, 3 months ago (2014-08-25 02:26:24 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/420663003/diff/80001/extensions/browser/api/bluetooth/OWNERS File extensions/browser/api/bluetooth/OWNERS (right): https://codereview.chromium.org/420663003/diff/80001/extensions/browser/api/bluetooth/OWNERS#newcode1 extensions/browser/api/bluetooth/OWNERS:1: ikarienator@chromium.org Please remove ikarienator while you're here; no ...
6 years, 3 months ago (2014-08-29 06:46:13 UTC) #3
Lei Zhang
presubmit says I need more extensions OWNERS.
6 years, 3 months ago (2014-08-29 19:08:12 UTC) #5
James Cook
stamp lgtm
6 years, 3 months ago (2014-08-29 20:23:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/420663003/140001
6 years, 3 months ago (2014-08-29 22:27:09 UTC) #8
Lei Zhang
TBRing keybuk@ since the "new" DEPS entry isn't actually new.
6 years, 3 months ago (2014-08-29 23:18:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/420663003/140001
6 years, 3 months ago (2014-08-29 23:24:44 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:140001) as 514ba805e656b8f6fe30077d2ab3472a92a12b63
6 years, 3 months ago (2014-08-29 23:46:36 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:49 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8146daf0a5a91e4bedec34cfe0b942803c36aa90
Cr-Commit-Position: refs/heads/master@{#292719}

Powered by Google App Engine
This is Rietveld 408576698