Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: components/sync_driver/data_type_manager_impl.h

Issue 420633002: [Sync] Cleanup datatype configuration error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync_driver/data_type_manager.cc ('k') | components/sync_driver/data_type_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/data_type_manager_impl.h
diff --git a/components/sync_driver/data_type_manager_impl.h b/components/sync_driver/data_type_manager_impl.h
index 6beb108b049070489c8f219d2d84074110e46bf6..84f96a8f9274d9c57cb593648f66a9c8e47136df 100644
--- a/components/sync_driver/data_type_manager_impl.h
+++ b/components/sync_driver/data_type_manager_impl.h
@@ -68,7 +68,9 @@ class DataTypeManagerImpl : public DataTypeManager,
const syncer::DataTypeAssociationStats& association_stats) OVERRIDE;
virtual void OnModelAssociationDone(
const DataTypeManager::ConfigureResult& result) OVERRIDE;
- virtual void OnSingleDataTypeWillStop(syncer::ModelType type) OVERRIDE;
+ virtual void OnSingleDataTypeWillStop(
+ syncer::ModelType type,
+ const syncer::SyncError& error) OVERRIDE;
// Used by unit tests. TODO(sync) : This would go away if we made
// this class be able to do Dependency injection. crbug.com/129212.
@@ -80,8 +82,7 @@ class DataTypeManagerImpl : public DataTypeManager,
friend class TestDataTypeManager;
// Abort configuration and stop all data types due to configuration errors.
- void Abort(ConfigureStatus status,
- const syncer::SyncError& error);
+ void Abort(ConfigureStatus status);
// Returns the priority types (control + priority user types).
// Virtual for overriding during tests.
« no previous file with comments | « components/sync_driver/data_type_manager.cc ('k') | components/sync_driver/data_type_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698