Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 420623002: Remove duplicated copy of networking_private_event_router_factory (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated copy of networking_private_event_router_factory Is also in chrome_browser_extensions_chromeos_sources. BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 5 months ago (2014-07-24 22:31:00 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-25 04:51:24 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-25 04:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/420623002/1
6 years, 5 months ago (2014-07-25 04:55:48 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:36:23 UTC) #5
Message was sent while issue was closed.
Change committed as 285489

Powered by Google App Engine
This is Rietveld 408576698