Enable bot_update for chromium codesearch

Enable bot_update for chromium codesearch

This changes the codesearch builder on chromium.fyi to split out all of its
dependencies into top level solutions (instead of one massive build/ dep) and
turns on bot_update.

The reason this is done in conjunction with turning on bot_update is because
gclient is not able to have slashes in the solution name.

BUG=393781, 351896
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286555

[Ryan Tseng, 2014-07-28 21:51:50]

zty: You've poke codesearch before, right?  Can you take a look at this?

This CL (1) splits out chrome/trunk/tools/* into top level solutions, then (2)
turns on bot_update, which makes them git.  afaik the checkout being git should
have no impact on codesearch.  I've tested this locally and bot_update completes
correctly, and compiles.  The package_source portion is still running.

[zty, 2014-07-29 18:05:06]

https://codereview.chromium.org/420603015/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/420603015/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:569: elif parsed_url.scheme == 'https' and
'googlesource' in parsed_url.netloc:
What is this for?

[Ryan Tseng, 2014-07-29 18:16:55]

https://codereview.chromium.org/420603015/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/420603015/diff/1/scripts/slave/bot_update.py#...
scripts/slave/bot_update.py:569: elif parsed_url.scheme == 'https' and
'googlesource' in parsed_url.netloc:
On 2014/07/29 18:05:05, zty wrote:
> What is this for?

So there are 4 conditions:
1. If the url is a buildspec url (used on official builders)
2. If the url is a recognized svn url
3. (newly added) If the url was a git url already
4. None of the above

So the new assumption here that wasn't here before is that the master can now
pass in Git urls (instead of assuming all urls passed in by the master are svn).
This is made in conjunction with the master change that changes all the svn urls
into git urls.

[zty, 2014-07-29 18:29:20]

lgtm

[Ryan Tseng, 2014-07-29 18:36:42]

The CQ bit was checked by hinoka@google.com

[commit-bot: I haz the power, 2014-07-29 18:37:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hinoka@chromium.org/420603015/1

[commit-bot: I haz the power, 2014-07-29 18:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 18:37:13]

Failed to apply patch for build/scripts/slave/bot_update.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/scripts/slave/bot_update.py
  Hunk #1 FAILED at 262.
  Hunk #2 succeeded at 534 (offset -34 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
build/scripts/slave/bot_update.py.rej

Patch:       build/scripts/slave/bot_update.py
Index: scripts/slave/bot_update.py
diff --git build/scripts/slave/bot_update.py build/scripts/slave/bot_update.py
index
0290236a48234ef1c1a333a76b60793b78169ffc..353b8dda1811fa60185aabcda184128a89fc8f08
100755
--- a/build/scripts/slave/bot_update.py
+++ b/build/scripts/slave/bot_update.py
@@ -262,8 +262,6 @@ ENABLED_SLAVES.update(internal_data.get('ENABLED_SLAVES',
{}))
 # be disabled.
 DISABLED_BUILDERS = {
     'chromium.fyi': [
-        'Chromium Linux Codesearch',
-        'ChromiumOS Codesearch',
         # ClusterFuzz relies on svn revisions to do bisection checks.
         # crbug.com/377963
         'Win SyzyASAN LKGR',
@@ -568,6 +566,8 @@ def solutions_to_git(input_solutions):
       solution['deps_file'] = path.join('build', buildspec_name, '.DEPS.git')
     elif parsed_path in RECOGNIZED_PATHS:
       solution['url'] = RECOGNIZED_PATHS[parsed_path]
+    elif parsed_url.scheme == 'https' and 'googlesource' in parsed_url.netloc:
+      pass
     else:
       warnings.append('path %r not recognized' % parsed_path)
       print 'Warning: %s' % (warnings[-1],)

[Ryan Tseng, 2014-07-30 17:48:15]

The CQ bit was checked by hinoka@google.com

[commit-bot: I haz the power, 2014-07-30 17:48:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hinoka@chromium.org/420603015/20001

[commit-bot: I haz the power, 2014-07-30 17:49:48]

Change committed as 286555