Issue 420603012: Remove ContainerNode overload for NodeTraversal::nextSkippingChildren()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420603012: Remove ContainerNode overload for NodeTraversal::nextSkippingChildren() (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove ContainerNode overload for NodeTraversal::nextSkippingChildren() Remove ContainerNode overload for NodeTraversal::nextSkippingChildren() as it adds no benefit compared to the one taking a Node in argument. The nextSkippingChildren() implementation does not involves visiting the children (and thus calling firstChild() / lastChild()). Therefore, there is no benefit to knowing that the argument is a ContainerNode (unlike for NodeTraversal::next()). This CL also does the same for ElementTraversal::nextSkippingChildren(). R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179055

Patch Set 1 #

Patch Set 2 : Remove the one from ElementTraversal as well #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -24 lines)			Patch
	M	Source/core/dom/ElementTraversal.h	View	1	4 chunks	+4 lines, -12 lines	0 comments	Download
	M	Source/core/dom/NodeTraversal.h	View		3 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420603012/20001

6 years, 4 months ago (2014-07-28 20:28:48 UTC) #4

Message was sent while issue was closed.

Change committed as 179055

Expand Messages | Collapse Messages