Split Screen mode implementation

athena/wm/window_manager_impl.cc

Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index 51c1e60bb7d302f2ff424bc6b9a53cc75c15949d..478296e5da669ca7658f38ad11736f1461177c80 100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -8,6 +8,7 @@
 #include "athena/input/public/accelerator_manager.h"
 #include "athena/screen/public/screen_manager.h"
 #include "athena/wm/bezel_controller.h"
+#include "athena/wm/mru_window_tracker.h"
 #include "athena/wm/public/window_manager_observer.h"
 #include "athena/wm/split_view_controller.h"
 #include "athena/wm/window_overview_mode.h"
@@ -34,6 +35,8 @@ class WindowManagerImpl : public WindowManager,
   // WindowManager:
   virtual void ToggleOverview() OVERRIDE;
 
+  virtual bool IsOverviewModeActive() OVERRIDE { return overview_; }

[oshima, 2014/08/08 18:00:40]

nit: virtual body should be in .cc

[mfomitchev, 2014/08/08 18:40:28]

Done.

+
  private:
   enum Command {
     COMMAND_TOGGLE_OVERVIEW,
@@ -61,6 +64,7 @@ class WindowManagerImpl : public WindowManager,
                                   const ui::Accelerator& accelerator) OVERRIDE;
 
   scoped_ptr<aura::Window> container_;
+  scoped_ptr<MruWindowTracker> mru_window_tracker_;
   scoped_ptr<WindowOverviewMode> overview_;
   scoped_ptr<BezelController> bezel_controller_;
   scoped_ptr<SplitViewController> split_view_controller_;
@@ -96,8 +100,10 @@ WindowManagerImpl::WindowManagerImpl() {
   container_.reset(ScreenManager::Get()->CreateDefaultContainer(params));
   container_->SetLayoutManager(new AthenaContainerLayoutManager);
   container_->AddObserver(this);
+  mru_window_tracker_.reset(new MruWindowTracker(container_.get()));
   bezel_controller_.reset(new BezelController(container_.get()));
-  split_view_controller_.reset(new SplitViewController());
+  split_view_controller_.reset(new SplitViewController(
+      container_.get(), mru_window_tracker_.get(), this));
   bezel_controller_->set_left_right_delegate(split_view_controller_.get());
   container_->AddPreTargetHandler(bezel_controller_.get());
   instance = this;
@@ -137,9 +143,17 @@ void WindowManagerImpl::SetInOverview(bool active) {
     return;
 
   if (active) {
-    overview_ = WindowOverviewMode::Create(container_.get(), this);
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
                       OnOverviewModeEnter());
+    // Re-stack all windows in the order defined by mru_window_tracker_.
+    aura::Window::Windows window_list = mru_window_tracker_->GetWindowList();
+    aura::Window::Windows::iterator it;
+    for (it = window_list.begin(); it != window_list.end(); ++it) {
+      container_->StackChildAtTop(*it);
+    }

[oshima, 2014/08/08 18:00:40]

nit: nuke {}

[mfomitchev, 2014/08/08 18:40:28]

Done.

+    overview_ = WindowOverviewMode::Create(container_.get(),
+                                           mru_window_tracker_.get(),
+                                           this);
   } else {
     overview_.reset();
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
@@ -165,8 +179,7 @@ void WindowManagerImpl::RemoveObserver(WindowManagerObserver* observer) {
 }
 
 void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
-  CHECK_EQ(container_.get(), window->parent());
-  container_->StackChildAtTop(window);
+  mru_window_tracker_->MoveToFront(window);
   wm::ActivateWindow(window);
   SetInOverview(false);
 }