athena/wm/public/window_list_provider.h - Issue 420603011: Split Screen mode implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/wm/public/window_list_provider.h

Issue 420603011: Split Screen mode implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_view

Patch Set: Fixing a rebase glitch Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #ifndef ATHENA_WM_PUBLIC_WINDOW_LIST_PROVIDER_H_
	oshima 2014/08/09 05:07:03 you need license comment here. Sorry, I missed in you need license comment here. Sorry, I missed in the review. mfomitchev 2014/08/09 18:29:56 Done. Show quoted text On 2014/08/09 05:07:03, oshima wrote: > you need license comment here. Sorry, I missed in the review. Done.
	2 #define ATHENA_WM_PUBLIC_WINDOW_LIST_PROVIDER_H_

	3

	4 #include "athena/athena_export.h"

	5 #include "ui/aura/window.h"

	6

	7 namespace athena {

	8

	9 // Interface for an ordered list of aura::Window objects.

	10 class ATHENA_EXPORT WindowListProvider {

	11 public:

	12 virtual ~WindowListProvider() {}

	13

	14 // Returns an ordered list of windows.
	sadrul 2014/08/09 13:32:40 Please document the ordering here. Please document the ordering here. mfomitchev 2014/08/09 18:29:56 My thinking was that this is just an interface and My thinking was that this is just an interface and the ordering is up to the subclass. MryWindowTracker does document the ordering.
	15 virtual aura::Window::Windows GetWindowList() const = 0;

	16

	17 // Moves the window to the front of the list.

	18 virtual void MoveToFront(aura::Window* window) = 0;

	19 };

	20

	21 } // namespace athena

	22

	23 #endif // ATHENA_WM_PUBLIC_WINDOW_LIST_PROVIDER_H_

OLD	NEW