Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: trunk/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 420603009: Revert 178910 "Revert 178850 "DevTools: Introduce createRawLocat..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/devtools/front_end/sdk/DebuggerModel.js
===================================================================
--- trunk/Source/devtools/front_end/sdk/DebuggerModel.js (revision 178930)
+++ trunk/Source/devtools/front_end/sdk/DebuggerModel.js (working copy)
@@ -577,6 +577,18 @@
},
/**
+ * @param {!ConsoleAgent.CallFrame} callFrame
+ * @return {!WebInspector.DebuggerModel.Location}
+ */
+ createRawLocationByConsoleCallFrame: function(callFrame)
+ {
+ // FIXME(62725): console stack trace line/column numbers are one-based.
+ var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
+ var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
+ return new WebInspector.DebuggerModel.Location(this.target(), callFrame.scriptId, lineNumber, columnNumber);
+ },
+
+ /**
* @return {boolean}
*/
isPaused: function()
« no previous file with comments | « trunk/Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698