Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: trunk/Source/devtools/front_end/network/NetworkPanel.js

Issue 420603009: Revert 178910 "Revert 178850 "DevTools: Introduce createRawLocat..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 /** 1009 /**
1010 * @param {!WebInspector.NetworkRequest} request 1010 * @param {!WebInspector.NetworkRequest} request
1011 * @return {!Element} 1011 * @return {!Element}
1012 */ 1012 */
1013 _generateScriptInitiatedPopoverContent: function(request) 1013 _generateScriptInitiatedPopoverContent: function(request)
1014 { 1014 {
1015 var stackTrace = request.initiator.stackTrace; 1015 var stackTrace = request.initiator.stackTrace;
1016 var framesTable = document.createElement("table"); 1016 var framesTable = document.createElement("table");
1017 for (var i = 0; i < stackTrace.length; ++i) { 1017 for (var i = 0; i < stackTrace.length; ++i) {
1018 var stackFrame = stackTrace[i]; 1018 var stackFrame = stackTrace[i];
1019 var rawLocation = request.target().debuggerModel.createRawLocationBy ConsoleCallFrame(stackFrame);
1019 var row = document.createElement("tr"); 1020 var row = document.createElement("tr");
1020 row.createChild("td").textContent = stackFrame.functionName || WebIn spector.UIString("(anonymous function)"); 1021 row.createChild("td").textContent = stackFrame.functionName || WebIn spector.UIString("(anonymous function)");
1021 row.createChild("td").textContent = " @ "; 1022 row.createChild("td").textContent = " @ ";
1022 row.createChild("td").appendChild(this._linkifier.linkifyLocation(re quest.target(), stackFrame.url, stackFrame.lineNumber - 1, stackFrame.columnNumb er - 1)); 1023 row.createChild("td").appendChild(this._linkifier.linkifyRawLocation (rawLocation));
1023 framesTable.appendChild(row); 1024 framesTable.appendChild(row);
1024 } 1025 }
1025 return framesTable; 1026 return framesTable;
1026 }, 1027 },
1027 1028
1028 _updateColumns: function() 1029 _updateColumns: function()
1029 { 1030 {
1030 var detailedMode = !!this._detailedMode; 1031 var detailedMode = !!this._detailedMode;
1031 var visibleColumns = {"name": true}; 1032 var visibleColumns = {"name": true};
1032 if (detailedMode) { 1033 if (detailedMode) {
(...skipping 1984 matching lines...) Expand 10 before | Expand all | Expand 10 after
3017 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 3018 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
3018 { 3019 {
3019 var aValue = a._request[propertyName]; 3020 var aValue = a._request[propertyName];
3020 var bValue = b._request[propertyName]; 3021 var bValue = b._request[propertyName];
3021 if (aValue > bValue) 3022 if (aValue > bValue)
3022 return revert ? -1 : 1; 3023 return revert ? -1 : 1;
3023 if (bValue > aValue) 3024 if (bValue > aValue)
3024 return revert ? 1 : -1; 3025 return revert ? 1 : -1;
3025 return a._request.indentityCompare(b._request); 3026 return a._request.indentityCompare(b._request);
3026 } 3027 }
OLDNEW
« no previous file with comments | « trunk/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | trunk/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698