Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 420603008: Cleanup return values in chrome/browser/net (Closed)

Created:
6 years, 5 months ago by lucinka.brozkova
Modified:
6 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup return values in chrome/browser/net This CL turns const by value return values into const by ref. Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying. BUG=393155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285669

Patch Set 1 #

Patch Set 2 : Removing unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/net/firefox_proxy_settings.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/url_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lucinka.brozkova
Hi mmenke@, Could you please do an OWNERS review? Thank you. Lucie
6 years, 5 months ago (2014-07-25 19:05:16 UTC) #1
mmenke
LGTM
6 years, 5 months ago (2014-07-25 19:10:02 UTC) #2
lucinka.brozkova
The CQ bit was checked by lucinka.brozkova@gmail.com
6 years, 5 months ago (2014-07-25 19:11:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lucinka.brozkova@gmail.com/420603008/20001
6 years, 5 months ago (2014-07-25 19:14:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 20:00:08 UTC) #5
mmenke
On 2014/07/25 20:00:08, I haz the power (commit-bot) wrote: > FYI, CQ is re-trying this ...
6 years, 5 months ago (2014-07-25 20:03:08 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 20:42:44 UTC) #7
Message was sent while issue was closed.
Change committed as 285669

Powered by Google App Engine
This is Rietveld 408576698