Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 420603005: Revert 285507 "NaCl: Update revision in DEPS, r13506 -> r13526" (Closed)

Created:
6 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285507 "NaCl: Update revision in DEPS, r13506 -> r13526" > NaCl: Update revision in DEPS, r13506 -> r13526 > > This pulls in the following Native Client changes: > > r13507: (noelallen) Reapply patch which was reverted due to conflict. > r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' > MAX_PATH limit > r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep > function names. > r13510: (dschuff) Disable flaky sandboxed translator tests on mac > r13511: (dschuff) Update revision for PNaCl r13466->r13509 > r13512: (ncbray) Fix untrusted.gypi and build_nexe.py > r13513: (noelallen) Cleanup bionic build script. > r13514: (dyen) Added initial pass of nacl_irt_code_data_alloc. > r13515: (sbc) Use custom exception class for errors in package_version. > r13516: (hidehiko) Non-SFI mode: SCONS_NONSFI_TC clean up. > r13517: (hidehiko) Non-SFI Mode: Refactoring. Provide non-SFI version of > nacl_irt_query_core. > r13518: (binji) Revert "Non-SFI mode: SCONS_NONSFI_TC clean up." > r13519: (bradnelson) Make the trybots fail early if 'git cl try' is mistakenly > used. > r13520: (bradnelson) Make build_nexe.py rebuild when script itself has changed. > r13521: (noelallen) Updates GN dep, and cleans up some toolchain prep > definitions to make it easier to debug what's going on. > r13523: (teravest) Add embedder interface for fatal log messages. > r13524: (bradnelson) Passing --config-name to build_nexe.py for all arches. > r13525: (teravest) Create a sel_ldr_launcher_base target. > r13526: (teravest) Revert "Add embedder interface for fatal log messages." > > R=ncbray@chromium.org > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > > CC: native-client-reviews@googlegroups.com, binji@chromium.org, bradnelson@google.com, dschuff@chromium.org, dyen@chromium.org, hidehiko@chromium.org, jvoung@google.com, ncbray@chromium.org, noelallen@google.com, sbc@chromium.org, teravest@chromium.org > > Review URL: https://codereview.chromium.org/418213002 TBR=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M trunk/src/DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 5 months ago (2014-07-25 07:25:56 UTC) #1
tyoshino (SeeGerritForStatus)
Committed patchset #1 manually as r285519 (tree was closed).
6 years, 5 months ago (2014-07-25 07:26:07 UTC) #2
tyoshino (SeeGerritForStatus)
On 2014/07/25 07:26:07, tyoshino wrote: > Committed patchset #1 manually as r285519 (tree was closed). ...
6 years, 5 months ago (2014-07-25 07:26:58 UTC) #3
jvoung (off chromium)
6 years, 5 months ago (2014-07-25 18:01:02 UTC) #4
Message was sent while issue was closed.
Looks similar to the problem that Derek saw earlier this week, while trying to
roll in r13511 (the PNaCl update to mingw). It looks like it did trigger the
"short temp file name fallback", since it generated a random cd7fc386 suffix w/:

-o
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o

but it looks like it still tacked on the verbose bits w/ the
"cd7fc386.o---...---.po":

'../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o---irt_shim_ppapi.c---.po':
The system cannot find the path specified'

which is supposed to be replaced by solely the cd7fc386.


=====

Tail end of log

Given build dir C:\b\build\slave\Win_x64_Builder\build\src\out\Release_x64\

[753/4646 | 62.052] STAMP
obj\ppapi\native_client\src\untrusted\pnacl_irt_shim\browser.actions_rules_copies.stamp
[754/4646 | 62.295] STAMP
obj\ppapi\native_client\src\untrusted\pnacl_support_extension\pnacl_support_extension.actions_depends.stamp
[755/4646 | 62.576] ACTION pnacl_support_extension:
generate_pnacl_support_extension_ce6de5b84437bef198ef5f35f7849473
[756/4646 | 63.573] STAMP
obj\third_party\modp_b64\modp_b64_nacl.actions_rules_copies.stamp
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x64
aot_target_build_newlib_x86_32_nonsfi_nlib__via_pnacl__9a72619ad1172c9b055155a397e1f2a7..rsp
..\..\ppapi\native_client\src\untrusted\pnacl_irt_shimerror: unable to open
output file
'../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o---irt_shim_ppapi.c---.po':
'Error opening output file
'../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o---irt_shim_ppapi.c---.po':
The system cannot find the path specified'
1 error generated.
..\..\..\..\..\out\Release_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c
irt_shim_ppapi.c -o
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o
-MD -MF
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o.d
--target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch
x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT
-Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions
-Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field
-Wno-char-subscripts -Wno-unused-function -D__STDC_LIMIT_MACROS=1
-D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1
-D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX
-DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS
-D_ATL_NO_OPENGL -D_HAS_EXCEPTIONS=0 -D_SECURE_ATL -DCHROMIUM_BUILD
-DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP
-DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0
-DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0
-I../../../../../out/Release_x64/gen/tc_pnacl_newlib/include -I../../../../..
-I../../../../../out/Release_x64/gen -I../../../../../third_party/wtl/include
-std=gnu99

FAILED: Command
'..\..\..\..\..\out\Release_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c
irt_shim_ppapi.c -o
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o
-MD -MF
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/aot.gen/pnacl_newlib_x86_32-nonsfi/aot/irt_shim_ppapi_cd7fc386.o.d
--target=i686-unknown-nacl --pnacl-allow-native --pnacl-allow-translate -arch
x86-32-nonsfi -O2 -g -Wall -fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT
-Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions
-Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field
-Wno-char-subscripts -Wno-unused-function -D__STDC_LIMIT_MACROS=1
-D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1
-D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX
-DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS
-D_ATL_NO_OPENGL -D_HAS_EXCEPTIONS=0 -D_SECURE_ATL -DCHROMIUM_BUILD
-DTOOLKIT_VIEWS=1 -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP
-DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DNO_TCMALLOC -DENABLE_EGLIMAGE=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_DEPRECATE -DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DWIN_PDF_METAFILE_FOR_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0
-DNACL_OSX=0 -DNACL_LINUX=0 -DNACL_ANDROID=0
-I../../../../../out/Release_x64/gen/tc_pnacl_newlib/include -I../../../../..
-I../../../../../out/Release_x64/gen -I../../../../../third_party/wtl/include
-std=gnu99' returned non-zero exit status 1

ninja: build stopped: subcommand failed.

C:\b\depot_tools\python276_bin\python.exe C:\b\build\goma\goma_ctl.py stat
request: total=541 success=541 failure=0
 goma: finished=521 cache_hit=10 aborted=19 retry=0 fail=0
 local: run=26 killed=6 finished=1
files: requested=79929 uploaded=14718 missed=0
memory: consuming=391311360
http_rpc: query=74 retry=0 timeout=0 error=0

Powered by Google App Engine
This is Rietveld 408576698