Issue 420603002: Use tighter typing in editing/

Issue 420603002: Use tighter typing in editing/ (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed, adamk

CC:
blink-reviews, groby+blinkspell_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Use tighter typing in editing/ Use tighter typing in editing/ to improve code readability. This CL focuses mainly on htmlediting.cpp / htmlediting.h. R=adamk@chromium.org, leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178881

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -131 lines)			Patch
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/DeleteSelectionCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/editing/InsertListCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/InsertTextCommand.cpp	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/editing/SpellChecker.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/VisiblePosition.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/editing/VisibleSelection.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/editing/VisibleUnits.cpp	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/editing/htmlediting.h	View	7 chunks	+16 lines, -15 lines	0 comments	Download
M	Source/core/editing/htmlediting.cpp	View	22 chunks	+67 lines, -62 lines	0 comments	Download
M	Source/core/editing/markup.cpp	View	5 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

leviw_travelin_and_unemployed

I might have done a few commands at a time to make this easier to ...

6 years, 5 months ago (2014-07-24 23:27:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420603002/20001

6 years, 5 months ago (2014-07-24 23:28:40 UTC) #4

Message was sent while issue was closed.

Change committed as 178881