Style, comments, refactoring in run-bisect-perf-regression.py.

Style, comments, refactoring in run-bisect-perf-regression.py.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285681

[qyearsley, 2014-07-24 21:36:37]

Running pylint on run-bisect-perf-regression.py yields 0 warnings after this
change.

Comments on individual refactorings in the source code.

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
File tools/run-bisect-perf-regression.py (right):

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:24: bisect =
__import__('bisect-perf-regression')
Even if run-bisect-perf-regression.py is run from another directory, I believe
this should work.

This should basically be
  import bisect-perf-regression as bisect
if "bisect-perf-regression" were a valid module name.

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:44: filename = 'goma_ctl.bat' if os.name ==
'nt' else 'goma_ctl.sh'
I thought this is simpler than how it was done with _GetExecutablePath.

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:48: if self._HasGomaPath():
Goma is not spelled with all caps in its official documentation.

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:131: return True
I believe that this is equivalent.

PTAL to verify.

[prasadv, 2014-07-25 00:00:43]

lgtm

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
File tools/run-bisect-perf-regression.py (right):

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:357: This function also
causes sheriffs to scream at us:)
?

[qyearsley, 2014-07-25 00:22:29]

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
File tools/run-bisect-perf-regression.py (right):

https://codereview.chromium.org/420583002/diff/1/tools/run-bisect-perf-regres...
tools/run-bisect-perf-regression.py:357: This function also
On 2014/07/25 00:00:42, prasadv wrote:
> causes sheriffs to scream at us:)
> ? 

Yeah, that's an unintended side-effect of this function :-P

I think that I was in the middle of writing that it also outputs the config step
(the rest of the steps along with their annotations are output in the
sub-process) -- so I just extracted that out here.

[qyearsley, 2014-07-25 19:48:29]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-07-25 19:49:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qyearsley@chromium.org/420583002/40001

[commit-bot: I haz the power, 2014-07-25 21:06:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-07-25 21:20:54]

Change committed as 285681