Issue 420563008: [usb_gadget p12] Basic tests of usb_service using the USB test gadget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420563008: [usb_gadget p12] Basic tests of usb_service using the USB test gadget. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Ken Rockot(use gerrit already), pfeldman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[usb_gadget p12] Basic tests of usb_service using the USB test gadget. Two optional tests for usb_service::UsbService that use the new USB test gadget to verify that we can enumerate devices and detect connect and disconnect events. Since not all testers have this hardware the tests are only run when the --enable-gadget-tests flag is provided. BUG=396682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287051

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -1 line)			Patch
M	components/usb_service/usb_service_impl.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	device/device_tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	device/usb/DEPS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	device/usb/usb_service_unittest.cc	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Reilly Grant (use Gerrit)

Adding pfeldman to review device/usb depending on components/usb_service.

6 years, 5 months ago (2014-07-25 23:13:49 UTC) #1

Reilly Grant (use Gerrit)

The CQ bit was checked by reillyg@chromium.org

6 years, 4 months ago (2014-08-01 17:35:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/420563008/40001

6 years, 4 months ago (2014-08-01 17:37:47 UTC) #5

Message was sent while issue was closed.

Change committed as 287051

Expand Messages | Collapse Messages