Issue 420553002: gs_utils: when uploading a whole dir using IF_NEW, check for existence of multiple files in a singl…

Issue 420553002: gs_utils: when uploading a whole dir using IF_NEW, check for existence of multiple files in a singl… (Closed)

Created:
6 years, 5 months ago by epoger

Modified:
6 years, 5 months ago

Reviewers:
borenet

CC:
reviews_skia.org, rmistry

Base URL:
https://skia.googlesource.com/common.git@master

Visibility:
Public.

More Reviews

Description

gs_utils: when uploading a whole dir using IF_NEW, check for existence of multiple files in a single operation BUG=skia:2778 R=borenet@google.com Committed: https://skia.googlesource.com/common/+/0625d3a

Patch Set 1 : add upload_if test for upload_dir_contents() #

Patch Set 2 : check for existence of multiple files at once #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -25 lines)			Patch
	M	py/utils/gs_utils.py	View	1	3 chunks	+57 lines, -23 lines	0 comments	Download
	M	py/utils/gs_utils_manualtest.py	View		3 chunks	+83 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

Eric- PTAL as of patchset 2. I suspect this will provide a huge speedup for ...

6 years, 5 months ago (2014-07-25 14:54:36 UTC) #1

borenet

On 2014/07/25 14:54:36, epoger wrote: > Eric- PTAL as of patchset 2. > > I ...

6 years, 5 months ago (2014-07-25 15:17:06 UTC) #2

epoger

On 2014/07/25 15:17:06, borenet wrote: > Wow. So I guess first-time uploads will take about ...

6 years, 5 months ago (2014-07-25 15:19:27 UTC) #3

epoger

Committed patchset #2 manually as r0625d3a (presubmit successful).

6 years, 5 months ago (2014-07-25 15:19:54 UTC) #5

borenet

6 years, 5 months ago (2014-07-25 15:20:08 UTC) #6

Message was sent while issue was closed.

On 2014/07/25 15:19:27, epoger wrote:
> On 2014/07/25 15:17:06, borenet wrote:
> > Wow.  So I guess first-time uploads will take about that long, and
subsequent
> > uploads (assuming there aren't a lot of flakes) will be much faster?
> 
> Yes, although I also plan to attack the first-upload time by uploading
multiple
> files in parallel.

Yeah, that should help.

Expand Messages | Collapse Messages