Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/site_instance_unittest.cc

Issue 42054: Stop using renderer specific host ids in ResourceDispatcher. This allows it ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/resource_message_filter.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_instance_unittest.cc
===================================================================
--- chrome/browser/site_instance_unittest.cc (revision 11493)
+++ chrome/browser/site_instance_unittest.cc (working copy)
@@ -177,16 +177,15 @@
// Test to ensure GetProcess returns and creates processes correctly.
TEST_F(SiteInstanceTest, GetProcess) {
- // Ensure that GetProcess returns the process based on its host id.
+ // Ensure that GetProcess returns a process.
scoped_ptr<TestingProfile> profile(new TestingProfile());
- scoped_ptr<BrowserRenderProcessHost> host1(
- new BrowserRenderProcessHost(profile.get()));
+ scoped_ptr<RenderProcessHost> host1;
scoped_refptr<SiteInstance> instance(
SiteInstance::CreateSiteInstance(profile.get()));
- instance.get()->set_process_host_id(host1.get()->host_id());
- EXPECT_EQ(host1.get(), instance.get()->GetProcess());
+ host1.reset(instance.get()->GetProcess());
+ EXPECT_TRUE(host1.get() != NULL);
- // Ensure that GetProcess creates a new process if no host id is set.
+ // Ensure that GetProcess creates a new process.
scoped_refptr<SiteInstance> instance2(
SiteInstance::CreateSiteInstance(profile.get()));
scoped_ptr<RenderProcessHost> host2(instance2.get()->GetProcess());
« no previous file with comments | « chrome/browser/renderer_host/resource_message_filter.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698