chrome/browser/ui/views/location_bar/zoom_bubble_view.cc - Issue 420533002: zoom bubble: Close if anchor is clicked while bubble is showing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

Issue 420533002: zoom bubble: Close if anchor is clicked while bubble is showing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

index 93cd822305711477837c6e7397ff970cbeb056cc..081b8b2e8256a50a55c2c71cda00e17a0e5a41c7 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

@@ -112,8 +112,9 @@ void ZoomBubbleView::CloseBubble() {

// static

bool ZoomBubbleView::IsShowing() {

- // The bubble may be in the process of closing.

- return zoom_bubble_ != NULL && zoom_bubble_->GetWidget()->IsVisible();

+ // The bubble is considered showing while closing.

+ return zoom_bubble_ != NULL && (zoom_bubble_->GetWidget()->IsVisible() ||

+ zoom_bubble_->GetWidget()->IsClosed());

}

// static