Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2651)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 420533002: zoom bubble: Close if anchor is clicked while bubble is showing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
index 98d4a9297e0de6cc204eb6636ef6fa07297151e7..764282435af0e641d427602d8369561d12fede12 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
@@ -19,7 +19,7 @@ class BubbleIconView : public views::ImageView {
};
explicit BubbleIconView(CommandUpdater* command_updater, int command_id);
- virtual ~BubbleIconView();
+ ~BubbleIconView() override;
// Returns true if a related bubble is showing.
virtual bool IsBubbleShowing() const = 0;
@@ -28,17 +28,20 @@ class BubbleIconView : public views::ImageView {
virtual void OnExecuting(ExecuteSource execute_source) = 0;
// views::ImageView:
- virtual void GetAccessibleState(ui::AXViewState* state) override;
- virtual bool GetTooltipText(const gfx::Point& p, base::string16* tooltip)
- const override;
- virtual bool OnMousePressed(const ui::MouseEvent& event) override;
- virtual void OnMouseReleased(const ui::MouseEvent& event) override;
- virtual bool OnKeyPressed(const ui::KeyEvent& event) override;
+ void GetAccessibleState(ui::AXViewState* state) override;
+ bool GetTooltipText(const gfx::Point& p, base::string16* tooltip) const
+ override;
+ bool OnMousePressed(const ui::MouseEvent& event) override;
+ void OnMouseReleased(const ui::MouseEvent& event) override;
+ bool OnKeyPressed(const ui::KeyEvent& event) override;
// ui::EventHandler:
- virtual void OnGestureEvent(ui::GestureEvent* event) override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
private:
+ // Calls OnExecuting and runs |command_id_| with a valid |command_updater_|.
+ void ExecuteCommand(ExecuteSource source);
+
// The CommandUpdater for the Browser object that owns the location bar.
CommandUpdater* command_updater_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698