Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 420523002: cc: Don't rasterize large layers at maximum scale before scale animations (Closed)

Created:
6 years, 5 months ago by ajuma
Modified:
6 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick, nduca
Project:
chromium
Visibility:
Public.

Description

cc: Don't rasterize large layers at maximum scale before scale animations Layers with a scale animation are currently rasterized at the animation's maximum scale when the animation starts. However, for large layers, this approach consumes an excessive amount of memory. This CL restricts the 'rasterize at maximum scale' approach to layers that grow no larger than the viewport at maximum scale. BUG=395760 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285656

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 chunks +56 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ajuma
This is one part of a two-part plan for fixing memory usage during scale animations ...
6 years, 5 months ago (2014-07-25 15:58:32 UTC) #1
enne (OOO)
I'm sad about how many heuristics we have about rastering at the right scale, but ...
6 years, 5 months ago (2014-07-25 18:47:29 UTC) #2
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 5 months ago (2014-07-25 18:54:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/420523002/20001
6 years, 5 months ago (2014-07-25 18:55:33 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 20:12:57 UTC) #5
Message was sent while issue was closed.
Change committed as 285656

Powered by Google App Engine
This is Rietveld 408576698